Skip to content

feat: Update requeue time and remove unnecessary state check.#97

Merged
minhng22 merged 1 commit intoAzure:mainfrom
minhng22:imc-ref
Jun 14, 2022
Merged

feat: Update requeue time and remove unnecessary state check.#97
minhng22 merged 1 commit intoAzure:mainfrom
minhng22:imc-ref

Conversation

@minhng22
Copy link
Member

Description of your changes

feat: Update requeue time and remove unnecessary state check.

Addressing #95

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing #95

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster state is enum, so I don't think this CR can be created with a state different than the 2 I defined. I tried that in controller test.

Copy link
Contributor

@Arvindthiru Arvindthiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minhng22 minhng22 merged commit 882e8db into Azure:main Jun 14, 2022
@minhng22 minhng22 deleted the imc-ref branch June 15, 2022 05:07
zhiying-lin added a commit to zhiying-lin/fleet that referenced this pull request Jun 25, 2025
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants